Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Add watermark on the pro ResponsiveChartContainer #13398

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jun 6, 2024

I'm hesitating between reexporting the container like I'm currently doing (<ResponsiveChartContainer />), or exporting them with a pro suffix <ResponsiveChartContainerPro />.

@flaviendelangle Do you have some insight on this aspect? the reexport only add watermark, and it's still unsure if we will add behavior to this component

@alexfauquette alexfauquette added plan: Pro Impact at least one Pro user component: charts This is the name of the generic UI component, not the React module! labels Jun 6, 2024
@alexfauquette alexfauquette requested a review from JCQuintas June 6, 2024 10:18
@mui-bot
Copy link

mui-bot commented Jun 6, 2024

Deploy preview: https://deploy-preview-13398--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 57a4e78

@flaviendelangle
Copy link
Member

I'm hesitating between reexporting the container like I'm currently doing (), or exporting them with a pro suffix .

Sorry but I don't understand the difference 😆

@alexfauquette
Copy link
Member Author

Sorry but I don't understand the difference 😆

😅 Effectively, I copy pasted the same

  • ResponsiveChartContainer: current solution (same naming but component with a watermark)
  • ResponsiveChartContainerPro: other solution (different naming but only user-facing difference is the watermark)

@JCQuintas
Copy link
Member

We should probably follow what the other packages do

@JCQuintas
Copy link
Member

But I noticed each package does a different thing 😅

@JCQuintas
Copy link
Member

I would probably go with the DataGrid solution if we want to always load the new functionalities on the Pro package. This means disallowing the use of ResponsiveChartContainer

@flaviendelangle
Copy link
Member

If people need to use the pro version (which is the case here), I'd keep the Pro suffix to avoid confusion and somehow prevent users from user the community one.

@flaviendelangle
Copy link
Member

But I noticed each package does a different thing 😅

Yeah, it's hard to be 100% consistent on this topic, the trade-off vary greatly across the packages.
Calling the grid DataGrid on all the packages would not be nice, but on the other hand calling the range picker DateRangePickerPro when it has no free version is super heavy.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 7, 2024
Copy link

github-actions bot commented Jun 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 11, 2024
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should we also block the use of the ResponsiveChartContainer?

@alexfauquette
Copy link
Member Author

should we also block the use of the ResponsiveChartContainer?

The ResponsiveChartContainer and ChartContainer are not exported by the @mui/x-charts-pro 👍

thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants